[CUDAX] Change memory pool type to also be a resource #6180
+539
−924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pciolkosz
force-pushed
the
make_memory_pool_type_a_resource
branch
from
457f50d to
f9391aa
Compare
This comment has been minimized.
This comment has been minimized.
davebayer
reviewed
Oct 10, 2025
cudax/include/cuda/experimental/__memory_resource/device_memory_resource.cuh
Show resolved
Hide resolved
cudax/include/cuda/experimental/__memory_resource/memory_resource_base.cuh
Outdated
Show resolved
Hide resolved
cudax/include/cuda/experimental/__memory_resource/memory_resource_base.cuh
Outdated
Show resolved
Hide resolved
cudax/include/cuda/experimental/__memory_resource/memory_resource_base.cuh
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
davebayer
approved these changes
Oct 15, 2025
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 57m 10s: Pass: 100%/42 | Total: 6h 47m | Max: 44m 28s | Hits: 94%/21329See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a memory pool type that you need to wrap into a resource type that references it in order to use it in allocations.
That step seems unnecessary, it's better to extend the memory pool type to also provide a resource interface. This way there is no potential dangling pool references and memory pool type can be packed into the type erased wrappers for resources.
Note: This change leaves the naming to be a bit inconsistent, I will do a follow up change to do a bunch of renames, in order to keep this PR focused on the implementation.